add 'Off' setting for power LED #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntingEcho
force-pushed
the
enable-power-led-off
branch
from
24b578e to
92a2f46
Compare
|
Looks like it would work |
|
Any plans on this getting merged any time ? |
|
I just tested, it seems, we can turn off the power LED under kernel 6.11 without this PR, see : #11 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11
upfront warning - I have no experience in firmware, and haven't worked with C in around a decade (or ever in a professional context). I haven't yet loaded this onto my own laptop to test as it's my daily-driver. Skepticism / thorough review is warranted :)
breath length is left alone, since it's breathing from 0 to 0. Disabling breath may be better for battery life?