Load platform settings from config #76
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
force-pushed
the
config-file
branch
from
1e27730 to
0022a18
Compare
|
serde can be built on uefi but toml can't |
|
Should let you specify an existing platform and override that. |
JohnAZoidberg
force-pushed
the
config-file
branch
from
0022a18 to
889b27e
Compare
|
Also would be useful to easily specify those at compiletime. |
This is useful instead of the commandline parameters --has-mec --pd-ports --pd-addrs when SMBIOS doesn't correctly detect the correct platform settings. - [x] Read from CWD - [x] Test on Windows - [x] Test on Linux - [ ] Test on UEFI - [x] Read from same folder as binary - [x] Test on Windows - [x] Test on Linux - [ ] Test on UEFI - [ ] Read from $XDG_CONFIG_HOME on Linux Sample config for Framework 13 AMD: ``` [platform] has_mec = false pd_addrs = [ 0x42, 0x40 ] pd_ports = [ 1, 2 ] ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
config-file
branch
from
889b27e to
dc0611d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful instead of the commandline parameters --has-mec --pd-ports --pd-addrs
when SMBIOS doesn't correctly detect the correct platform settings.
Sample config for Framework 13 AMD: