Skip to content

fp-brightness: Add support for V1 host command #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Mar 4, 2025

On new EC:

# Set different levels
> framework_tool.exe --fp-led-level medium
Fingerprint LED Brightness
  Requested:  Medium
  Brightness: 40%
> framework_tool.exe --fp-led-level high
Fingerprint LED Brightness
  Requested:  High
  Brightness: 55%

# Just get brightness 
> framework_tool.exe --fp-brightness
Fingerprint LED Brightness
  Requested:  High
  Brightness: 55%
# Set custom brightness
> framework_tool.exe --fp-brightness 32
Fingerprint LED Brightness
  Requested:  Custom
  Brightness: 32%

# Set new ultra-low level
> framework_tool.exe --fp-led-level ultra-low
Fingerprint LED Brightness
  Requested:  UltraLow
  Brightness: 8%
# Set new auto level
> framework_tool.exe --fp-led-level auto
Fingerprint LED Brightness
  Requested:  Auto
  Brightness: 55%

# Check which brightness auto results in (momentarily)
> framework_tool.exe --fp-brightness
Fingerprint LED Brightness
  Requested:  Auto
  Brightness: 8%

On old EC:

> sudo framework_tool --fp-brightness
Fingerprint LED Brightness
  Brightness: 8%

> sudo framework_tool --fp-brightness 42
[ERROR] EC Response Code: InvalidVersion

> sudo framework_tool --fp-led-level medium
Fingerprint LED Brightness
  Brightness: 40%

> sudo framework_tool --fp-led-level ultra-low
[ERROR] EC Response Code: InvalidParameter

> sudo framework_tool --fp-led-level auto
[ERROR] EC Response Code: InvalidParameter

> sudo framework_tool --fp-led-level 
Fingerprint LED Brightness
  Brightness: 8%

Must also have EC support

Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
V0:
- Set level (ultra-low, low, medium, high, auto)
- Get percentage

V1:
- Set percentage
- Get level (ultra-low, low, medium, high, auto)

Signed-off-by: Daniel Schaefer <dhs@frame.work>
@JohnAZoidberg
Copy link
Member Author

Tested on UEFI shell as well with new EC on Framework 13 AMD Ryzen AI 300.

Signed-off-by: Daniel Schaefer <dhs@frame.work>
@JohnAZoidberg JohnAZoidberg merged commit 4ff42b8 into main Mar 6, 2025
6 checks passed
@JohnAZoidberg JohnAZoidberg deleted the auto-custom branch April 25, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant