Skip to content

add commands to read/write gpu serial #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

add commands to read/write gpu serial #98

merged 1 commit into from
Apr 14, 2025

Conversation

kiram9
Copy link
Member

@kiram9 kiram9 commented Apr 4, 2025

TEST=Tested on platform to overwrite the serial
And I can see the serial updates to the new value after rebooting the EC.

@kiram9 kiram9 requested a review from JohnAZoidberg April 4, 2025 01:26
JohnAZoidberg
JohnAZoidberg reviewed Apr 10, 2025
View reviewed changes
framework_lib/src/chromium_ec/command.rs Outdated
/// Get gpu bay serial
GetGpuSerial = 0x3E1D,
/// Set gpu bay serial and program structure
SetGpuSerial = 0x3E1F,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh in EC source code this is called EC_CMD_PROGRAM_GPU_EEPROM

@JohnAZoidberg
Copy link
Member

I renamed it from --flash_gpu_descriptor to --flash-gpu-descriptor to fit the other existing commands.
And also allowed symbolic magic number: framework_tool.efi --flash_gpu_descriptor GPU FRAKMQCP41500ASSY1
Hmm should also allow hex format of magic numbe.r

@kiram9
Copy link
Member Author

kiram9 commented Apr 11, 2025

yes please enable hex values for magic number as well :)

@kiram9
Copy link
Member Author

kiram9 commented Apr 11, 2025

LGTM, but i authored, so cannot approve.

@kiram9 @JohnAZoidberg
Add commands to read/write GPU serial
87f2132 
TEST=Tested on platform to overwrite the serial
And I can see the serial updates to the new value after rebooting
the EC.

Signed-off-by: Kieran Levin <ktl@frame.work>
Co-Authored-By: Daniel Schaefer <dhs@frame.work>
@JohnAZoidberg
Copy link
Member

yes please enable hex values for magic number as well :)

Done. Can now use any of

framework_tool.efi --flash_gpu_descriptor GPU FRAKMQCP41500ASSY1
framework_tool.efi --flash_gpu_descriptor 13 FRAKMQCP41500ASSY1
framework_tool.efi --flash_gpu_descriptor 0x0D FRAKMQCP41500ASSY1

@JohnAZoidberg JohnAZoidberg merged commit 9ad012f into main Apr 14, 2025
5 of 6 checks passed
@JohnAZoidberg JohnAZoidberg deleted the fw16.dgpu_config branch April 14, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiram9 @JohnAZoidberg