Open/short detection #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
changed the title
Useful if not all SW pins are connected. It's good to disable disconnected ones. Otherwise it causes higher voltages spikes which can cause audible noise. Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
sw-enablement
branch
from
5a39462 to
51188d1
Compare
JohnAZoidberg
force-pushed
the
open-short
branch
2 times, most recently
from
767b9c4 to
84bab3e
Compare
|
References:
|
``` let open1 = matrix.device.check_open(&mut delay, 0x03, true).unwrap(); let open2 = matrix.device.check_open(&mut delay, 0x07, true).unwrap(); let open3 = matrix.device.check_open(&mut delay, 0x08, true).unwrap(); let open4 = matrix.device.check_open(&mut delay, 0x0C, true).unwrap(); let short1 = matrix.device.check_open(&mut delay, 0x03, false).unwrap(); let short2 = matrix.device.check_open(&mut delay, 0x07, false).unwrap(); let short2 = matrix.device.check_open(&mut delay, 0x07, false).unwrap(); let short3 = matrix.device.check_open(&mut delay, 0x08, false).unwrap(); let short4 = matrix.device.check_open(&mut delay, 0x0C, false).unwrap(); ``` Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
JohnAZoidberg
force-pushed
the
open-short
branch
from
84bab3e to
c0f26c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect which LEDs are connected and which aren't.
Useful to detect which kind of module we're running on.
E.g. early Framework prototype, later prototype, Adafruit module, ...
Doesn't quite work, hm :/ (Data seems wrong)