convert the get-threads service to zod (and fix a error with null firstname/lastname) #1762
+25
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smadbe
force-pushed
the
get-threads-to-zod
branch
from
a112c80 to
92cc638
Compare
smadbe
force-pushed
the
get-threads-to-zod
branch
2 times, most recently
from
16a8cef to
9608214
Compare
Iloveall
approved these changes
Aug 23, 2024
smadbe
force-pushed
the
get-threads-to-zod
branch
from
9608214 to
251724c
Compare
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/get-threads-to-zod/playwright-report/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a small mistake in the firstname/lastname parsing of this service (they may be null).
I fixed them and took the opportunity to convert to zod
Test cases