Better countdown by computing the offset between the frontend and the backend #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smadbe
force-pushed
the
explicit-entry
branch
8 times, most recently
from
422d984 to
37ef323
Compare
smadbe
force-pushed
the
countdown-time-sync
branch
from
2556d53 to
43c087b
Compare
smadbe
changed the title
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/countdown-time-sync/playwright-report/index.html |
Iloveall
approved these changes
Sep 10, 2024
smadbe
force-pushed
the
countdown-time-sync
branch
from
43c087b to
2f559b3
Compare
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/countdown-time-sync/playwright-report/index.html |
smadbe
force-pushed
the
countdown-time-sync
branch
from
2f559b3 to
3a0935a
Compare
…rceptor. use it in the top bar countdown
smadbe
force-pushed
the
countdown-time-sync
branch
from
3a0935a to
6da7a9b
Compare
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/countdown-time-sync/playwright-report/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order not to display a completely wrong countdown when a JS client has a completely wrong time, "compute" constantly the offset between the frontend and backend and apply it to the countdown.
Test cases