Extra time tab #1791
Extra time tab #1791
Conversation
smadbe
force-pushed
the
extra-time-tab
branch
from
bc2a968 to
ce385ff
Compare
| @else if (observedGroupInfo === undefined || false ) { <!-- loading--> | ||
| <alg-loading></alg-loading> | ||
| } | ||
| @else if (false ) { <!-- error--> |
| @else if (observedGroupInfo === null) { | ||
| <p i18n>This activity has a duration of {{ item.duration | readable }}. To list and add extra-time to some groups or users, start observation on them.</p> | ||
| } | ||
| @else if (observedGroupInfo === undefined || false ) { <!-- loading--> |
| ></alg-item-permissions> | ||
|
|
||
| <alg-tab-bar class="tab-bar" *ngIf="!!(shouldDisplayTabBar$ | async) && !fullFrameContentDisplayed" /> | ||
| @if (!(fullFrameContent$ | async)) { |
There was a problem hiding this comment.
Btw, recently I've found info about condition like that. The problem is that the first of value async is null and so false it could be reason of render component where it shouldn't.
Here is eslint rule with description https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/no-negated-async.md
Example: (fullFrameContent$ | async) === false
There was a problem hiding this comment.
As fullFrameContent$ is a subject, can it really be null? But anyway, its default value is "false" so we would want "null" to be consider as "false", so that's correct as it is, (fullFrameContent$ | async) === false would be wrong in this case.
| [itemData]="itemData" | ||
| ></alg-chapter-group-progress> | ||
| } | ||
| @if (!isObserving) { |
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/extra-time-tab/playwright-report/index.html |
Description
Create a new tab for the time-limited items. Currently, some backend service are still missing to complete the page, but most of it is ready already.
When it will be fully ready, I 'll ask you @Iloveall to add design and e2e tests to it.
Test cases
Case 1:
Case 2: