Changes approach for create e2e group, adds clean old e2e groups #1809
Conversation
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/improve-e2e-groups/playwright-report/index.html |
Iloveall
force-pushed
the
feature/improve-e2e-groups
branch
2 times, most recently
from
4e95ad0 to
e0e4c01
Compare
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/improve-e2e-groups/playwright-report/index.html |
Iloveall
force-pushed
the
feature/improve-e2e-groups
branch
from
e0e4c01 to
baff037
Compare
| await leftNavFirstChild.click(); | ||
|
|
||
| for (const groupName of groupNamesForRemove) { | ||
| const leftNavGroupLocator = page.locator('p-tree').getByText(groupName).first(); |
There was a problem hiding this comment.
The reason I'm not using group locator from collection is that the collection keeps position of element (nth(n)), and so if new group will be created during process (so left menu is updated with new positions) it will be failed. That's why need to get locator by name again
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/improve-e2e-groups/playwright-report/index.html |
Description
Improves creating of E2E groups, adds clear groups scenario. I've put criteria to remove generated groups that older than 1hr, as I don't think so the same e2e will work during this time (Before we spoke to remove groups from prev day)
Notes (out of scope, known isues, hints for reviewing code, ...) (optional)
Fixtures approach needs to be reorganise in separated PR as it will cause a lot of path changes in files
Test cases