Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"content" management refactoring #1832

Merged
merged 10 commits into from
Nov 25, 2024
Merged

"content" management refactoring #1832

merged 10 commits into from
Nov 25, 2024

Conversation

smadbe
Copy link
Contributor

@smadbe smadbe commented Nov 14, 2024

Description

A set of changes in preparation for future feature requests:

  • introduce a default skill as the default activity (not used yet)
  • introduce a new store: navigation, for instance just keeping the last activity, skill and group visited (to be used by the left menu later)
  • use store for group state in the same way it is already done for items (and users) and replacing the group datasource

Work better than before:

  • if error in group breadcrumbs (non existing/non visible group), the breadcrumb is "self-healed"
  • when starting observing a user, activity suggestion is shown

For the rest, we rely on the e2e tests and basic manual testing to ensure the behavior is still ok.

@smadbe smadbe force-pushed the refactor-navigation branch from f0d5774 to 35677f0 Compare November 14, 2024 17:01
@smadbe
Copy link
Contributor Author

smadbe commented Nov 14, 2024

@smadbe smadbe force-pushed the refactor-navigation branch from 9d62b5e to 93af15d Compare November 20, 2024 12:42
@smadbe smadbe changed the title introduce a default skill "content" management refactoring Nov 21, 2024
@smadbe smadbe marked this pull request as ready for review November 21, 2024 13:28
@smadbe smadbe requested a review from Iloveall November 21, 2024 13:28
@smadbe
Copy link
Contributor Author

smadbe commented Nov 21, 2024

e2e tests are not passing currently but I don't know what is related with the PR and what is not...

@smadbe smadbe force-pushed the refactor-navigation branch 2 times, most recently from a0421db to aa24681 Compare November 22, 2024 09:35
Copy link
Collaborator

@Iloveall Iloveall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase should fix e2e for PR

@smadbe smadbe force-pushed the refactor-navigation branch from aa24681 to 6ede315 Compare November 22, 2024 15:43
@smadbe smadbe force-pushed the refactor-navigation branch from 6ede315 to f69870f Compare November 25, 2024 15:50
@smadbe
Copy link
Contributor Author

smadbe commented Nov 25, 2024

@smadbe smadbe merged commit cf8eccc into master Nov 25, 2024
12 checks passed
@smadbe smadbe deleted the refactor-navigation branch November 25, 2024 17:25
Copy link

sentry-io bot commented Nov 28, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Unexpected missing id from group param groupRouteFromParams(deployments/tez-prod/2.48.... View Issue
  • ‼️ Error: Unexpected missing id from group param groupRouteFromParams(deployments/tez-prod/2.48.... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants