Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds empty content component #1836

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Adds empty content component #1836

merged 1 commit into from
Nov 19, 2024

Conversation

Iloveall
Copy link
Collaborator

@Iloveall Iloveall commented Nov 18, 2024

Description

Fixes #1669

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

I didn't found the icon given in design, so I took alternative from https://phosphoricons.com/

Any idea of other places where it may be applied?

I'll check and specify in new ticket

Test cases

  • Case 1:
    1. Given I am the usual user
    2. When I go to this page
    3. Then I see new design for empty content

@Iloveall Iloveall marked this pull request as draft November 18, 2024 15:07
@smadbe
Copy link
Contributor

smadbe commented Nov 18, 2024

@Iloveall Iloveall marked this pull request as ready for review November 18, 2024 15:34
@Iloveall Iloveall requested a review from smadbe November 18, 2024 15:34
@Iloveall Iloveall merged commit df1948f into master Nov 19, 2024
12 checks passed
@Iloveall Iloveall deleted the new-design/empty-skills branch November 19, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New design for empty list in skills
2 participants