Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds icon for validated item of history #1856

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

Iloveall
Copy link
Collaborator

@Iloveall Iloveall commented Dec 11, 2024

Description

Fixes #1849

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

It looks smaller but size is the same as other icons - 24px

Test cases

  • Case 1:

    1. Given I am the usual user
    2. When I go to this page
    3. Then I see new icon for validated item
  • Case 2:

    1. Given I am the usual user
    2. When I go to this page
    3. And I click on "Load more"
    4. Then I see new icon for validated item
    5. And I see the size of icons changed (from 24 to 32)

@Iloveall Iloveall marked this pull request as draft December 11, 2024 17:12
@smadbe
Copy link
Contributor

smadbe commented Dec 11, 2024

@Iloveall Iloveall marked this pull request as ready for review December 13, 2024 11:14
@Iloveall Iloveall requested a review from smadbe December 13, 2024 11:14
Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer if the icon was not duotone and would have the same size as the score ring (32x32?). Could you test that?

@smadbe
Copy link
Contributor

smadbe commented Dec 16, 2024

@Iloveall Iloveall requested a review from smadbe December 16, 2024 11:47
Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a flag icon for "Activity started", wasn't it?
image

@smadbe
Copy link
Contributor

smadbe commented Dec 16, 2024

@Iloveall
Copy link
Collaborator Author

There was a flag icon for "Activity started", wasn't it? image

The ngClass doesn't work properly (It removes ph-duotone for true condition because of other false condition with ph-duotone) so I've moved it into pipe

@Iloveall Iloveall requested a review from smadbe December 16, 2024 15:10
Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time, I don't not see the "validated" row anymore...
image

@Iloveall Iloveall force-pushed the feature/add-icon-in-front-validated branch from 314a0e7 to 5cddbf7 Compare December 17, 2024 12:16
@smadbe
Copy link
Contributor

smadbe commented Dec 17, 2024

@Iloveall
Copy link
Collaborator Author

2. this page

I've updated the test case, but didn't mention it, try updated link from usual user

@Iloveall Iloveall requested a review from smadbe December 17, 2024 12:47
Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply the same changes to the group view. (btw, I don't get why the code is so duplicated between these 2 components...)

pure: true,
standalone: true
})
export class LogActivityTypeIcon implements PipeTransform {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we try to suffix pipe classes by "Pipe"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@smadbe
Copy link
Contributor

smadbe commented Dec 18, 2024

@Iloveall
Copy link
Collaborator Author

Apply the same changes to the group view. (btw, I don't get why the code is so duplicated between these 2 components...)

I've checked those components, the difference I see are:

  • group logs has path suggestion, item logs doesn't
  • item logs has view/reload answer, group logs just view answer
  • item logs using getActivityLog, group logs getAllActivityLog

@Iloveall
Copy link
Collaborator Author

I've add new test case for group logs

@Iloveall Iloveall requested a review from smadbe December 18, 2024 09:10
@Iloveall Iloveall merged commit c92732a into master Dec 18, 2024
12 checks passed
@Iloveall Iloveall deleted the feature/add-icon-in-front-validated branch December 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History: add icon in front of "validated"
2 participants