-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds unlocked items dialog #1859
Conversation
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/display-unlocked-content-in-modal/playwright-report/index.html |
[draggable]="false" | ||
[closable]="false" | ||
i18n-header header="Unlocked content" | ||
styleClass="alg-permissions-edit-dialog" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't create new style classes, and I guess this one could be renamed to something more generic (like middle-size-dialog)
There should be a button in the top right corner, yes. Clicking on the background should also close the window (if it is just a flag) |
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/display-unlocked-content-in-modal/playwright-report/index.html |
Done |
Description
Fixes #1858
Notes (out of scope, known isues, hints for reviewing code, ...) (optional)
Unlocked items could be moved to separated component, I can do this in next PR if needed.
Is button on center enough or should be cross button in top right corner?
Test cases
Case 1:
Case 2: