Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unlocked items dialog #1859

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

Iloveall
Copy link
Collaborator

@Iloveall Iloveall commented Dec 18, 2024

Description

Fixes #1858

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

Unlocked items could be moved to separated component, I can do this in next PR if needed.

display a closable modal

Is button on center enough or should be cross button in top right corner?

Test cases

  • Case 1:

    1. Given I am the temp user
    2. When I go to this page
    3. And I solve the '****' version (loop 360 times: forward(1), rotate(1))
    4. Then I see modal with unlocked items
    5. Then I click on item
    6. Then I see opened item page
  • Case 2:

    1. Given I am the temp user
    2. When I go to this page
    3. And I solve the '****' version (loop 360 times: forward(1), rotate(1))
    4. Then I see modal with unlocked items
    5. Then I click on "Continue on the current content" button
    6. Then I see current task

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Iloveall Iloveall marked this pull request as draft December 18, 2024 12:29
@smadbe
Copy link
Contributor

smadbe commented Dec 18, 2024

[draggable]="false"
[closable]="false"
i18n-header header="Unlocked content"
styleClass="alg-permissions-edit-dialog"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't create new style classes, and I guess this one could be renamed to something more generic (like middle-size-dialog)

@Iloveall Iloveall marked this pull request as ready for review December 18, 2024 13:09
@Iloveall Iloveall requested a review from smadbe December 18, 2024 13:10
@smadbe
Copy link
Contributor

smadbe commented Dec 18, 2024

Is button on center enough or should be cross button in top right corner?

There should be a button in the top right corner, yes. Clicking on the background should also close the window (if it is just a flag)

@smadbe
Copy link
Contributor

smadbe commented Dec 18, 2024

@Iloveall
Copy link
Collaborator Author

Is button on center enough or should be cross button in top right corner?

There should be a button in the top right corner, yes. Clicking on the background should also close the window (if it is just a flag)

Done

@Iloveall Iloveall merged commit f4ebd80 into master Dec 19, 2024
12 checks passed
@Iloveall Iloveall deleted the feature/display-unlocked-content-in-modal branch December 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display unlocked content in a modal
2 participants