Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item route cleanup2 #1885

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Item route cleanup2 #1885

merged 4 commits into from
Jan 29, 2025

Conversation

smadbe
Copy link
Contributor

@smadbe smadbe commented Jan 27, 2025

Description

Few small refactoring to item route (to be reviewed one commit at a time):

  • improve how the current page is obtained
  • use only array of strings for item pages
  • clarify usage of url vs command in item router
  • move functions related to default item in a specific file

@smadbe smadbe requested a review from Iloveall January 27, 2025 16:04
@smadbe
Copy link
Contributor Author

smadbe commented Jan 27, 2025

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/item-route-cleanup2/playwright-report/index.html

Base automatically changed from item-route-cleanup to master January 29, 2025 10:07
@smadbe smadbe merged commit 8a3f82a into master Jan 29, 2025
12 checks passed
@smadbe smadbe deleted the item-route-cleanup2 branch January 29, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iloveall Iloveall Iloveall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smadbe @Iloveall