-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ethereum.md #517
base: main
Are you sure you want to change the base?
Update ethereum.md #517
Conversation
Add an Ethereum tool
WalkthroughThe changes in the pull request involve updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docs/blockchains/ethereum.md (2)
41-41
: Suggestion: Further improve the title's accuracyThe capitalization of "Pokemon" in the tutorial title "Learn Vyper by building a Pokemon Game" is an improvement. However, for complete accuracy, consider using the official spelling with the accent: "Pokémon".
Suggested change:
- Learn Vyper by building a Pokemon Game + Learn Vyper by building a Pokémon Game🧰 Tools
🪛 LanguageTool
[grammar] ~41-~41: The name of this game or TV show is spelled with an accent.
Context: ...ome-vyper) - Learn Vyper by building a Pokemon Game -...(POKEMON)
Line range hint
110-111
: Approved with correction: Fix language name in link textThe addition of an Arabic language resource is valuable for improving accessibility. However, there's a minor error in the link text.
Please apply the following correction:
-- [Ethereum Hindi](https://ethereum.org/ar/learn/) Main website for Ethereum Content, Communities, and Events in Arabic ++ [Ethereum Arabic](https://ethereum.org/ar/learn/) Main website for Ethereum Content, Communities, and Events in ArabicThis change ensures consistency with the section title and accurately represents the linked resource.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- docs/blockchains/ethereum.md (3 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/blockchains/ethereum.md
[grammar] ~41-~41: The name of this game or TV show is spelled with an accent.
Context: ...ome-vyper) - Learn Vyper by building a Pokemon Game -...(POKEMON)
🔇 Additional comments (3)
docs/blockchains/ethereum.md (3)
37-37
: Approved: Grammatical improvement in tutorial titleThe pluralization of "contract" to "contracts" in the tutorial title "Learn Solidity: The COMPLETE Beginner's Guide" is correct. This change accurately reflects the common terminology used in the Ethereum ecosystem, where "smart contracts" is the standard plural form.
Line range hint
1-111
: Overall assessment: Valuable additions with minor improvements neededThis update to the Ethereum resources document brings several positive changes:
- Grammatical improvement in the Solidity tutorial title.
- Addition of Drizzle to the development tools section.
- Inclusion of an Arabic language resource.
These changes enhance the document's comprehensiveness and accessibility. However, a few minor adjustments are recommended:
- Correct the spelling of "Pokémon" in the Vyper tutorial title.
- Verify the current status of Drizzle and update the information if necessary.
- Fix the language name in the Arabic resource link text.
Once these small issues are addressed, this update will significantly improve the resource list for Ethereum developers and learners.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~36-~36: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...als - [Learn Blockchain, Solidity, and Full Stack JavaScript Development](https://www.fre...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[style] ~36-~36: Consider removing “of” to be more concise
Context: ... will give you a full introduction into all of the core concepts related to blockchain, sm...(ALL_OF_THE)
[grammar] ~41-~41: The name of this game or TV show is spelled with an accent.
Context: ...ome-vyper) - Learn Vyper by building a Pokemon Game -...(POKEMON)
67-68
: Approved with suggestion: Verify Drizzle's current statusThe addition of Drizzle to the Ethereum Development Tools section is valuable. However, the link points to an archived version (archive.trufflesuite.com), which might indicate that the tool is no longer actively maintained.
Consider:
- Verifying if there's a more current version or repository for Drizzle.
- If not, add a note mentioning that it's an archived tool but still potentially useful for reference.
To verify the current status of Drizzle, you can run the following script:
✅ Verification successful
Approved with correction: Update Drizzle link to active repository
Drizzle is actively maintained, with recent updates in the trufflesuite/drizzle repository. The current link points to an archived version, which may no longer reflect its active status.
Consider:
- Updating the link to the active repository: https://github.com/trufflesuite/drizzle
- Ensuring the documentation accurately reflects the current state and resources of Drizzle.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if there's a more current version of Drizzle # Check the GitHub repository echo "Checking GitHub repository..." gh repo view trufflesuite/drizzle # Check if there are any recent updates or forks echo "Checking for recent updates or popular forks..." gh repo view trufflesuite/drizzle --json updatedAt,forkCount,latestRelease # Check if there are any mentions of Drizzle's status in the Truffle docs echo "Checking Truffle documentation for Drizzle status..." curl -s https://trufflesuite.com/docs | grep -i drizzleLength of output: 8036
Add an Ethereum tool
Summary by CodeRabbit
New Features
Bug Fixes