Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Let wait_for_ecu() recognize the cli --timeout value #174

Merged
merged 1 commit into from
Jun 29, 2022
Merged

fix: Let wait_for_ecu() recognize the cli --timeout value #174

merged 1 commit into from
Jun 29, 2022

Conversation

rumpelsepp
Copy link
Member

No description provided.

@rumpelsepp rumpelsepp requested a review from fkglr as a code owner June 20, 2022 11:55
@rumpelsepp rumpelsepp added the bug Something isn't working label Jun 20, 2022
@rumpelsepp rumpelsepp requested a review from peckto June 20, 2022 11:56
@rumpelsepp rumpelsepp linked an issue Jun 20, 2022 that may be closed by this pull request
wait for ECU timeout should use cli value #166
Closed
@rumpelsepp rumpelsepp added this to the v1.0.1 milestone Jun 20, 2022
@peckto
Copy link
Contributor

peckto commented Jun 27, 2022

We have a hard coded sleep in the _wait_for_ecu function:

gallia/src/gallia/uds/ecu.py

Lines 325 to 330 in a86d67b

while True:
try:
await asyncio.sleep(1)
await self.reconnect()
await self.ping()
break

This will cause problems with timeout values < 1sec

@rumpelsepp
Copy link
Member Author

@peckto fixed.

@rumpelsepp rumpelsepp force-pushed the wait_for_ecu2 branch 2 times, most recently from cda76ac to 72e06cd Compare June 28, 2022 12:43
@rumpelsepp @peckto
fix: Let wait_for_ecu() recognize the cli --timeout value
3d35ae3 
Co-authored-by: Tobias Specht <tobias.specht@aisec.fraunhofer.de>
@rumpelsepp rumpelsepp modified the milestones: v1.0.1, v1.0.2 Jun 28, 2022
@rumpelsepp rumpelsepp added the maint Needs cherry-picking to X.X-maint branch label Jun 28, 2022
@rumpelsepp rumpelsepp merged commit 8f225c7 into master Jun 29, 2022
@rumpelsepp rumpelsepp deleted the wait_for_ecu2 branch June 29, 2022 06:37
@rumpelsepp rumpelsepp added maint-merged Ported to maintenance branch and removed maint Needs cherry-picking to X.X-maint branch labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckto peckto peckto approved these changes

@fkglr fkglr Awaiting requested review from fkglr fkglr is a code owner

Assignees
No one assigned
Labels
bug Something isn't working maint-merged Ported to maintenance branch
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.

wait for ECU timeout should use cli value
2 participants
@rumpelsepp @peckto