Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scan-sessions): add fast search option #180

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

fkglr
Copy link
Contributor

@fkglr fkglr commented Jun 24, 2022

Adds the option --fast which still finds any (session A, session B) transition that the current version finds, but leaves out many of the other (mostly useless) stacks.

@fkglr fkglr requested review from rumpelsepp and peckto as code owners June 24, 2022 14:36
@fkglr fkglr force-pushed the scan-session-fast branch from 8ff3d79 to 183bf0b Compare June 24, 2022 15:04
@fkglr fkglr changed the title feat(scan-sessions): add fast search option, which only searches for one path to each session feat(scan-sessions): add fast search option Jun 24, 2022
… from each session, ignoring the remaining stack
@fkglr fkglr force-pushed the scan-session-fast branch from 183bf0b to e21dbe3 Compare June 24, 2022 15:07
@peckto
Copy link
Contributor

peckto commented Jun 27, 2022

Please add a test-case for the new option:

- name: Test scan-sessions
run: |
poetry run gallia scan-sessions --target "tcp-lines://127.0.0.1:20162" --no-dumpcap --depth 2

@fkglr
Copy link
Contributor Author

fkglr commented Jun 27, 2022

Please add a test-case for the new option:

- name: Test scan-sessions
run: |
poetry run gallia scan-sessions --target "tcp-lines://127.0.0.1:20162" --no-dumpcap --depth 2

I've added a small test case similar to the main one for scan-session. A depth limitation is in my opinion not necessary here, as the scanner runs fast enough.

@fkglr fkglr self-assigned this Jun 27, 2022
@fkglr fkglr merged commit bb1e488 into master Jun 28, 2022
@fkglr fkglr deleted the scan-session-fast branch June 28, 2022 10:40
@rumpelsepp rumpelsepp added the enhancement New feature or request label Jun 28, 2022
@rumpelsepp rumpelsepp added this to the v1.1.0 milestone Jun 28, 2022
@rumpelsepp rumpelsepp added the maint Needs cherry-picking to X.X-maint branch label Jun 30, 2022
@rumpelsepp rumpelsepp modified the milestones: v1.1.0, v1.0.2 Jun 30, 2022
@rumpelsepp
Copy link
Member

scheduled for v1.0.2 as well, since another patch depends on this.

@rumpelsepp rumpelsepp added maint-merged Ported to maintenance branch and removed maint Needs cherry-picking to X.X-maint branch labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maint-merged Ported to maintenance branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants