feat(db): store sessions in the database #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkglr
force-pushed
the
session-db
branch
2 times, most recently
from
342dc17 to
49aec0a
Compare
rumpelsepp
force-pushed
the
master
branch
6 times, most recently
from
72a5ecf to
41e0a13
Compare
fkglr
force-pushed
the
session-db
branch
5 times, most recently
from
138f7ed to
e0659f0
Compare
rumpelsepp
force-pushed
the
master
branch
3 times, most recently
from
981f73a to
5218514
Compare
fkglr
force-pushed
the
session-db
branch
2 times, most recently
from
692e1e7 to
2537d49
Compare
|
Increment Database Scheme Number? -> |
…nt run and session list
rumpelsepp
force-pushed
the
session-db
branch
from
2537d49 to
c562a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #17
The idea behind this pull request is to remove the currently in place session scans at the start of most of the scanners and to replace them with the results from a full session scan as delivered by the scan-sessions script.
Therefore, the corresponding information is stored in a separate database table.
There is however still work to do here.
Currently only the logging to the database and the usage of this information during a session change is implemented and it is not clear if the current format, which can only stores transitions but no other information, is sufficient. Or in other words, can a broader format add enough value to justify replacing the simple session transition format?