Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement color and terminal stuff with rich #188

Closed
wants to merge 1 commit into from
Closed

Conversation

rumpelsepp
Copy link
Member

@rumpelsepp rumpelsepp commented Jun 27, 2022

This lib https://rich.readthedocs.io/ does all the heavy lifting with detecting of terminal capabilities, detection of color systems, … We should just use it rather than implementing our own homebrewed terminal escape code stuff. This will help with the TUI as well which is scheduled in gallia v1.2.0.

It also supports progress bars: https://rich.readthedocs.io/en/latest/progress.html; #168

@rumpelsepp rumpelsepp requested a review from peckto as a code owner June 27, 2022 11:28
@rumpelsepp rumpelsepp marked this pull request as draft June 27, 2022 11:29
@rumpelsepp rumpelsepp added the enhancement New feature or request label Jun 27, 2022
@rumpelsepp rumpelsepp added this to the v1.1.0 milestone Jun 27, 2022
@rumpelsepp rumpelsepp closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant