fix: Raise a TimeoutError when wait_for_ecu() times out #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpelsepp
removed
maint
|
I thought about this. Rescheduled this for v1.1.0 for discussion. I will revert to the old behaviour in v1.0.3. |
rumpelsepp
force-pushed
the
master
branch
6 times, most recently
from
72a5ecf to
41e0a13
Compare
rumpelsepp
force-pushed
the
master
branch
3 times, most recently
from
981f73a to
5218514
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8f225c7 removed the return value of
wait_for_ecu(). This brakes a gallia plugin which we use internally. I think it makes more sense to just raise theTimeoutError. @fkglr any thoughts?