meta file #235
Merged
meta file #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rumpelsepp
commented
Aug 25, 2022
•
rumpelsepp
commented
- fix: Raise an exception when the connection is lost
- feat: Silence the logs of sqlite
- fix: Fix accidently renamed variables
- feat: Add support for META file
peckto
reviewed
Aug 29, 2022
peckto
reviewed
Aug 29, 2022
| if self.ARTIFACTSDIR: | ||
| self.run_meta.exit_code = exit_code | ||
| self.run_meta.end_time = datetime.now(tz).isoformat() | ||
| data = msgspec.json.encode(self.run_meta) |
There was a problem hiding this comment.
Does msgspec support pretty printing?
There was a problem hiding this comment.
Yeah, looks a bit like what @dataclass does.
>>> class Dog(Struct):
... name: str
... breed: str
... is_good_boy: bool = True
Dog('snickers', breed='corgi')
peckto
reviewed
Aug 29, 2022
rumpelsepp
commented
Aug 29, 2022
rumpelsepp
force-pushed
the
meta-file
branch
4 times, most recently
from
8652a73 to
58f3ab1
Compare
rumpelsepp
force-pushed
the
meta-file
branch
3 times, most recently
from
caaa50b to
c83171d
Compare
For this use a new entry point for commands and unify the exception handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.