test xcp: revive xcp test script with CAN support #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkglr
force-pushed
the
test-xcp
branch
8 times, most recently
from
2a6364e to
a6b0dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the XCP primitive test tool is not exposed in gallia and only exists as an unreferenced file.
Furthermore it is lacking CAN support, as it makes use of the read() function, which is unsupported by the
can-rawtransport, which is however required for XCP on CAN communication.Therefore, this Pull request tries to fix both issues, by exposing the scanner on the CLI and by adding a CAN specific subclass of the XCPService class. Its master and slave parameters are retrieved by the two new CLI parameters
--can-masterand--can-slave