fix(dumpcap): Handle dumpcap invocation for unix transports #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is a flaw in the plugin interface. Plugins cannot specify how dumpcap should be invoked to capture traffic. The default is ethernet traffic. There are Unix transports available which are neither CAN traffic nor ethernet traffic. In this case the wrong method `_eth_cmd()` is called which cannot create a valid CLI for dumpcap.
|
Fixes the unix lines problem, but still has a pretty broad else branch... Anyhow, looks good to me, but haven't tested it. |
peckto
approved these changes
Jan 2, 2024
I added a point here: #479 under "Open for Discussion". We must default to ethernet for now, since our internal transports are ethernet. There is no API where transports could specify a command/something to capture traffic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a flaw in the plugin interface. Plugins cannot
specify how dumpcap should be invoked to capture traffic. The default
is ethernet traffic. There are Unix transports available which are
neither CAN traffic nor ethernet traffic. In this case the wrong
method
_eth_cmd()is called which cannot create a valid CLI fordumpcap.