fix(power-cycle): Make all occurrences of power cycles respect the --power-cycle-sleep parameter. #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpelsepp
reviewed
Apr 9, 2024
src/gallia/services/uds/ecu.py
Outdated
| await self.reconnect() | ||
| await self.wait_for_ecu() | ||
|
|
||
| resp = await self.set_session(0x01, config=config) | ||
| if isinstance(resp, service.NegativeResponse): | ||
| await self.power_cycle() | ||
| await self.power_cycle(**power_cycle_args) |
There was a problem hiding this comment.
Why not just self.power_cycle(sleep)?
There was a problem hiding this comment.
To allow for using the default sleep time defined in power_cycle() without repeating its definition in leave_session(). The latter might be easily overseen, should the definition in power_cycle() be updated in the future.
There was a problem hiding this comment.
When you use **power_cycle_args it does not get catched by mypy. When you use plain sleep as an argument it is all statically typed.
…power-cycle-sleep parameter.
rumpelsepp
force-pushed
the
power-cycle-sleep-everywhere
branch
from
952ac05 to
1ba52a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
--power-cycle-sleep, scanners can be told to sleep for a certain amount of time between power-off and power-on of the test-setup. However, this parameter was only actually used at one of multiple occurrences of these events in the code so far.