Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rework CLI argument parsing #9

Merged
merged 2 commits into from
Aug 17, 2022
Merged

feat: Rework CLI argument parsing #9

merged 2 commits into from
Aug 17, 2022

Conversation

rumpelsepp
Copy link
Member

@rumpelsepp rumpelsepp commented Apr 29, 2022 •
edited
Loading

No description provided.

@rumpelsepp rumpelsepp requested a review from peckto as a code owner April 29, 2022 09:14
@rumpelsepp rumpelsepp marked this pull request as draft April 29, 2022 09:14
@rumpelsepp rumpelsepp added this to the v1.1.0 milestone Apr 29, 2022
@rumpelsepp rumpelsepp removed the request for review from peckto April 29, 2022 13:32
@rumpelsepp rumpelsepp mentioned this pull request May 6, 2022
Merged
@rumpelsepp rumpelsepp mentioned this pull request May 9, 2022
Closed
@rumpelsepp rumpelsepp force-pushed the cli branch 2 times, most recently from cb14a18 to 4c1eb28 Compare May 10, 2022 11:55
@rumpelsepp
Copy link
Member Author

Fix description of discovery scanners; e.g. can-raw is needed by discovery scanner, but they document isotp. /cc @fkglr

@rumpelsepp rumpelsepp force-pushed the cli branch 2 times, most recently from c6f11b0 to e790cd6 Compare May 20, 2022 19:35
@rumpelsepp rumpelsepp linked an issue May 25, 2022 that may be closed by this pull request
(Sub)Command structure #81
Closed
@rumpelsepp rumpelsepp mentioned this pull request May 25, 2022
Merged
@rumpelsepp rumpelsepp force-pushed the cli branch 5 times, most recently from ea1d4b3 to 121314a Compare June 15, 2022 12:13
@rumpelsepp rumpelsepp added the enhancement New feature or request label Jun 15, 2022
@rumpelsepp rumpelsepp marked this pull request as ready for review June 15, 2022 12:14
@rumpelsepp rumpelsepp force-pushed the cli branch 4 times, most recently from 7c2e19a to 9fdb0ed Compare June 15, 2022 13:04
@rumpelsepp rumpelsepp force-pushed the cli branch 5 times, most recently from fe5d6c5 to e567766 Compare July 6, 2022 11:05
@rumpelsepp rumpelsepp force-pushed the cli branch 4 times, most recently from 6518294 to 7720d0e Compare July 6, 2022 13:24
@rumpelsepp rumpelsepp mentioned this pull request Jul 6, 2022
Merged
@rumpelsepp rumpelsepp force-pushed the cli branch 4 times, most recently from 4ab6b1c to 7f0db0a Compare July 7, 2022 09:25
@rumpelsepp rumpelsepp requested a review from fkglr as a code owner July 7, 2022 09:25
@rumpelsepp rumpelsepp force-pushed the cli branch 5 times, most recently from 90492a8 to 7389ca8 Compare July 7, 2022 10:38
@rumpelsepp rumpelsepp requested a review from peckto July 7, 2022 10:39
@rumpelsepp rumpelsepp force-pushed the cli branch 6 times, most recently from 67ecdb5 to 265ca48 Compare July 8, 2022 06:31
@rumpelsepp rumpelsepp force-pushed the cli branch 2 times, most recently from 109e9a3 to 68ab86f Compare August 17, 2022 10:38
@rumpelsepp rumpelsepp merged commit 2e1630b into master Aug 17, 2022
@rumpelsepp rumpelsepp deleted the cli branch August 17, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkglr fkglr Awaiting requested review from fkglr fkglr is a code owner

@peckto peckto Awaiting requested review from peckto peckto is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

(Sub)Command structure
1 participant
@rumpelsepp