Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a distinct kid value for individual keys / certificates #25

Closed
oxisto opened this issue Nov 25, 2021 · 2 comments · Fixed by #29
Closed

Use a distinct kid value for individual keys / certificates #25

oxisto opened this issue Nov 25, 2021 · 2 comments · Fixed by #29
Assignees

Comments

@oxisto
Copy link
Member

oxisto commented Nov 25, 2021

kid: 'default'

While our approach is technically compliant, it would be easier for the user if the kid is distinct. We could use a similar model as auth0, where kid is equal to x5t. See https://auth0.com/docs/security/tokens/json-web-tokens/json-web-key-set-properties

@schanzen
Copy link
Collaborator

Before thinking about the JWKS, the component first needs to support key rotations in the first place. Not even multiple keys as supported atm.

@bellebaum
Copy link
Contributor

#26 redoes the entire JWKS, adding support for key rollover and initial support for certificate chains to be distributed this way. If anyone would like to, it is ready to be reviewed.

  • old certificate/-chains and public/secret keys can be specified in omejdn.yml and the corresponding JWKs are advertised.
  • Where possible, x5t and x5c are specified in the JWKs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants