Support for Key Rollover #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowing for depricated public/secret keys
|
Before merging, I will fix a deviation from https://datatracker.ietf.org/doc/html/rfc7517#section-4.7, where certificates in a chain are supposed to appear in an array in |
JSON::JWK already implements RFC 7638
|
Quick update: For now, I will implement a workaround for manually separating PEM encoded Certificates. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #25 and adds support for key rollover.
Certificates have to be specified in
omejdn.yml.Their public keys are then distributed via
/.well-known/jwks.json, where each key is assigned akidequal to its certificate'sx5tthumbprint.If an operator does not specify a certificate, a self-signed cert is created with two-day validity for testing purposes.