Elevator #23
Open
Elevator #23
+310
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoguy1000
requested changes
Jan 31, 2025
|
If this is ready for final review and merge, make sure to take it out of draft |
legoguy1000
reviewed
Jan 31, 2025
Comment on lines
61
to
64
| public Command home() { | ||
| return raise(Constants.Elevator.HOME).andThen(() -> io.setVoltage(-0.1)) | ||
| .until(() -> (inputs.limitSwitch == true)); | ||
| } |
There was a problem hiding this comment.
Have we tested teh limit switch yet???
There was a problem hiding this comment.
no forgot about it will do either today or Saturday
legoguy1000
reviewed
Jan 31, 2025
legoguy1000
reviewed
Feb 1, 2025
legoguy1000
reviewed
Feb 1, 2025
legoguy1000
reviewed
Feb 1, 2025
legoguy1000
reviewed
Feb 1, 2025
legoguy1000
reviewed
Feb 1, 2025
| driver.povDown().onTrue(elevator.home()); | ||
| driver.povLeft().onTrue(elevator.p1()); | ||
| driver.leftTrigger().onTrue(elevator.p2()); | ||
| SmartDashboard.putNumber("elevatorVoltage", 1.0); |
There was a problem hiding this comment.
line 118-120 are the bind used to tune pid and line 121 was used for feedforward stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.