Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Example Datasets #17

Open
wfulp opened this issue Jun 6, 2019 · 8 comments
Open

Better Example Datasets #17

wfulp opened this issue Jun 6, 2019 · 8 comments
Assignees
Milestone

Comments

@wfulp
Copy link
Contributor

wfulp commented Jun 6, 2019

Currently example datasets have no group or time differences. The groups and time points were probably all sampled from the same distribution. It would be nice to have some differences to show off.

@mayerbry
Copy link
Contributor

mayerbry commented Jun 6, 2019

We should definitely just pull a few select data sets off of CDS using DataSpaceR. You can then store that code in data-raw file of the VISCfunctions package (http://r-pkgs.had.co.nz/data.html) so it's reproducible.

@wfulp
Copy link
Contributor Author

wfulp commented Jun 6, 2019

We should definitely just pull a few select data sets off of CDS using DataSpaceR. You can then store that code in data-raw file of the VISCfunctions package (http://r-pkgs.had.co.nz/data.html) so it's reproducible.

Would we still be able to make VISCFunctions public if we did this (so we can connect to travis)?

@wfulp
Copy link
Contributor Author

wfulp commented Jun 7, 2019

It would be nice to include more than 2 groups as well, so we could test the pairwise functions

@monicagerber
Copy link
Contributor

Would we still be able to make VISCFunctions public if we did this (so we can connect to travis)?

I think so because CDS is now publicly available (I think this happened when you were away).

@wfulp
Copy link
Contributor Author

wfulp commented Jun 26, 2019

Can we make these datasets tibbles instead of data.tables?

@wfulp
Copy link
Contributor Author

wfulp commented Jun 17, 2021

I've added in one CDS dataset into the package in the 1.2.0 release. Should we just replace all example datasets with CDS datasets?

@wfulp wfulp added this to the 1.3.0 milestone Jun 17, 2021
@mayerbry
Copy link
Contributor

I think so. As a bonus, a vignette showing the code of how to access and pull CDS data could be helpful.

@monicagerber
Copy link
Contributor

monicagerber commented Jun 17, 2021

Ju has some really nice vignettes for the DataSpaceR package.
Edit: and I think Jason was working on a cheat sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants