add strict tsconfig lint step

[FredKSchott]

Changes

• Follow up to support dev streaming logs #1203 (comment)
• Moves most strict tsconfig checks out of development build and into a separate "lint" step
• Allows for easier development without sacrificing PR/codebase quality.
• /cc @drwpow

Testing

• Added to CI

Docs

• N/A

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/6k0ead6rs
✅ Preview: https://snowpack-git-tsconfig-lint.pikapkg.vercel.app

[drwpow]

Approving because I don’t want to block, but soft-recommendation to having lint be its own job in GitHub actions (that only runs on one Node version, on Linux only). But as-is happy to merge this. Nice!

[drwpow]

We can remove the with: setting as we’re not using a matrix

[FredKSchott]

ah, no we still need to tell it which version of Node to use, but you are right that this env value was missing

[drwpow]

It defaults to LTS, but if you wanted to specify you could just add:

  with:
    node-version: '12.x'

[drwpow]

Or what you did above! 🙂

[drwpow]

Ah shoot… looks like yarn build may be required as part of the lint job? (so that TS knows where to find esinstall’s types)

[FredKSchott]

ah boo