Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding nofollow attribute to links #1240

Merged
merged 2 commits into from
Oct 9, 2020
Merged

adding nofollow attribute to links #1240

merged 2 commits into from
Oct 9, 2020

Conversation

melissamcewen
Copy link
Contributor

Changes

Adds a nofollow attribute to the ### Who's Using Snowpack? section so it should not affect the SEO rankings of the pages linked to.

Testing

Ran the docs test and no errors.

Docs

This is the docs.

@melissamcewen melissamcewen requested a review from a team as a code owner October 7, 2020 16:08
@vercel
Copy link

vercel bot commented Oct 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/5o0smbtbn
✅ Preview: https://snowpack-git-nofollow.pikapkg.vercel.app

@melissamcewen
Copy link
Contributor Author

I also propose we add a new discussion template https://github.com/pikapkg/snowpack/discussions/category_choices for adding these rather than directly telling users to put in a PR.

The template could be:

Site name:
Site URL:
How you're using Snowpack:
What do you like best about Snowpack?:
Any things you'd like to change about Snowpack? (or something along those lines)

@FredKSchott
Copy link
Owner

@melissamcewen +1 to discussion template, althought that feels the same as "show and tell". Maybe just clean up that template for this purpose?

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants