Allow result of load step to have map with binary data #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/d00vrzcko |
|
LGTM & makes sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously, the load step only allowed plugins with Buffer type results when there was a single result (i.e. not a map of results--see https://github.com/pikapkg/snowpack/blob/master/snowpack/src/build/build-pipeline.ts#L72). This PR allows a plugin to have multiple results, some string type, other Buffer type.
Testing
I tested this using a modified version of
snowpack-plugin-inliner; however, this is my first PR to snowpack and I'm unfamiliar with the test directory structure.Docs
This is a bug fix only.