Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hmr error overlay: don't read/write from document.body #1331

Merged
merged 1 commit into from
Oct 16, 2020
Merged

hmr error overlay: don't read/write from document.body #1331

merged 1 commit into from
Oct 16, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

  • skips writing the template to the body, and reading from the body
  • fixes issue where frontend frameworks would take over body entirely, clearing out the template

Testing

  • Covered by tests, and tested manually.

Docs

  • N/A

@FredKSchott FredKSchott requested a review from a team as a code owner October 16, 2020 04:41
@vercel
Copy link

vercel bot commented Oct 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/9vljloyot
✅ Preview: https://snowpack-git-fix-hmr-overlay.pikapkg.vercel.app

@FredKSchott FredKSchott merged commit c751555 into master Oct 16, 2020
@FredKSchott FredKSchott deleted the fix-hmr-overlay branch October 16, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FredKSchott