Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cross-mount imports #1355

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Add support for cross-mount imports #1355

merged 1 commit into from
Oct 18, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

  • Resolve the fully mounted URL of every imported file (don't just assume it's in the same mounted directory)
  • Bring 'dev' import resolver more in line with 'build' import resolver logic (would be good candidate to refactor into a single helper, but because one deals in URLs and the other in file paths, the implementations differ slightly in several places).

Testing

  • Added a test

Docs

  • N/A.

@vercel
Copy link

vercel bot commented Oct 18, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/mgzt0yzo3
✅ Preview: https://snowpack-git-fix-cross-mount-imports.pikapkg.vercel.app

@FredKSchott FredKSchott changed the base branch from master to optimize-304 October 18, 2020 09:39
@FredKSchott FredKSchott force-pushed the fix-cross-mount-imports branch from 8af1353 to 0f4d297 Compare October 18, 2020 09:43
Base automatically changed from optimize-304 to master October 18, 2020 21:29
@FredKSchott FredKSchott force-pushed the fix-cross-mount-imports branch from 0f4d297 to 1b02f8a Compare October 18, 2020 21:30
@FredKSchott FredKSchott force-pushed the fix-cross-mount-imports branch from 1b02f8a to e615a8f Compare October 18, 2020 21:40
@FredKSchott FredKSchott merged commit 07a1216 into master Oct 18, 2020
@FredKSchott FredKSchott deleted the fix-cross-mount-imports branch October 18, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FredKSchott