use regex for detecting import.meta #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/3ochcxrzx |
FredKSchott
reviewed
Oct 20, 2020
| @@ -30,7 +30,7 @@ export function wrapImportMeta({ | |||
| env: boolean; | |||
| config: SnowpackConfig; | |||
| }) { | |||
| if (!code.includes('import.meta')) { | |||
| if (!/import\s*\.\s*meta/.test(code)) { | |||
There was a problem hiding this comment.
this is a pretty hot code path, can you move the regex creation outside of the function?
FredKSchott
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The code that detects
import.meta, in order to inject the HMR client etc, is using a naivecode.includes('import.meta')check. This updates it to use a more robust regular expression, that can catch things likewhich could be injected by tools like Prettier.
Testing
I changed one of the tests that uses
import.meta.hot, but wasn't sure how to update the snapshot, so it's currently failing.Docs
No docs, bug fix only