Added lang specifier to script tag, i.e., lang='typescript' #1411
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/2rhifyxwf |
| @@ -1,4 +1,4 @@ | |||
| <script> | |||
There was a problem hiding this comment.
Doesn’t Svelte recommend lang="ts" instead?
There was a problem hiding this comment.
I put some thought into it. I went with typescript because for someone just starting out it takes fewer cycles to process than lang="ts". Svelte favors ts because it's shorter. I think templates should be more instructional than optimal, but I'm happy to change it to whatever you prefer.
There was a problem hiding this comment.
Thanks for the explanation! To be clear: I was asking as a Svelte novice, and genuinely didn’t know 🙂. I too favor the clarity of typescript now that you’ve explained it. Happy to merge.
Changes
Targets app-template-svelte-typescript.
Adds language specifier to script block. This signals the svelte language server to process the enclosed based on the specified attribute, typescript, in this case.
See svelte language server docs for more info.
Testing
Tested in started project with vscode and svelte for vscode plugin. Warnings related to types disappeared.
Docs
No docs added. Template enhancement/bug fix.