fix: replace removing the addTrailingSlash with removeTrailingSlash and deleted installOptions.alias options #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/ir5f3p172 |
iam-frankqiu
changed the title
FredKSchott
reviewed
Oct 29, 2020
| @@ -143,9 +143,6 @@ Options: | |||
| - Treeshake your dependencies to optimize your installed files. Snowpack will scan your application to detect which exact imports are used from each package, and then will remove any unused imports from the final install via dead-code elimination (aka tree shaking). | |||
| - **`installOptions.installTypes`** | `boolean` | |||
| - Install TypeScript type declarations with your packages. Requires changes to your [tsconfig.json](#typescript) to pick up these types. | |||
| - **`installOptions.alias`** | `{[mapFromPackageName: string]: string}` | |||
There was a problem hiding this comment.
bah, this is so old. Thanks for catching!
|
LGTM, the less tricky we can make these inputs and the more we can clean them for the user, the better |
peterhpchen
pushed a commit
to peterhpchen/snowpack
that referenced
this pull request
Oct 31, 2020
…nd deleted installOptions.alias options (FredKSchott#1432) * fix: replace removing the addTrailingSlash with removeTrailingSlash. * docs: deleted installOptions.alias options * docs: deleted installOptions.alias
melissamcewen
pushed a commit
that referenced
this pull request
Nov 17, 2020
* React + Snowpack Guide (#1309) * adding react guide * fixing page title * fixing a sentence * copy edits * copy edits * Refactoring CSS/Diffing copy paste solution Spinning the CSS into seperate files to make them easier to refactor, testing a solution for diffing copy/paste * copy edits * copy edits, restructuring * adding some images * image optmization, frame * adding more images * Update repository URL * Incorporate guides.css * Add more guides styling * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Fix indentation * changing header image * type in bash command * fixing typo * fixing typo * fixing typo * revising folder structure section * adding video * updating video * adding back gif * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * edits * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * copy edits * twitter share Co-authored-by: Drew Powers <drew@pow.rs> Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * [WIP] Initial migration of docs to Snowpack (#1413) * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * removing JS out of template * Docs split into multiple pages (#1437) * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * removing docs folder, moving to pages * moving get started * removing JS out of template * removing refs to building md * creating index page * organizing files * cleaning up files * reorganizing based on 1430 * rearranging headings, removing comments * adding menu items * rearranging menu * fixing back link * removing top nav * splitting up into guides * adding home header * readding subpage header * adding titles to front matter * trying to fix this bug * removing redirect * fixing issues from feedback * removing overview from home page * removing test for anchors since it's no longer a long page * letting it pass with no tests * removing build * stub for docs readme * removing JSX guide (#1490) * Move plugin-related guide stubs to plugins (#1492) * moving a couple of guides to plugins * deleting svelte * Moving Create-Snowpack-App to its own page, minor changes to Getting Started page (#1494) * refactoring getting started, create-snowpack-app page * fixing typo * fixing typo * fixing typo * moving in menu * deleting cra docs * removing tailwind and postcss guide stubs (#1493) * removing supported libraries stub * removing eslint * outline/draft of getting started * copywriting * deleting overview, copy edits and image descriptions * copy edits * Plugins refactor (#1582) * merging in plugin page * linking to getting started * 1467 * #1457 * #1451 * #1445 * #1432 * 1457 * #1515 * fixing menu * adding search index * removing old file * removing old file * resolve issues * merging in master * add a sub-page navigation sidebar (#1586) * splitting up deployment guide, copy edits * fixing link * style guide * splitting up into pages (#1628) Co-authored-by: Drew Powers <drew@pow.rs> Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> Co-authored-by: Fred K. Schott <fkschott@gmail.com>
FredKSchott
added a commit
that referenced
this pull request
Nov 17, 2020
* React + Snowpack Guide (#1309) * adding react guide * fixing page title * fixing a sentence * copy edits * copy edits * Refactoring CSS/Diffing copy paste solution Spinning the CSS into seperate files to make them easier to refactor, testing a solution for diffing copy/paste * copy edits * copy edits, restructuring * adding some images * image optmization, frame * adding more images * Update repository URL * Incorporate guides.css * Add more guides styling * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Fix indentation * changing header image * type in bash command * fixing typo * fixing typo * fixing typo * revising folder structure section * adding video * updating video * adding back gif * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * edits * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * copy edits * twitter share Co-authored-by: Drew Powers <drew@pow.rs> Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * [WIP] Initial migration of docs to Snowpack (#1413) * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * removing JS out of template * Docs split into multiple pages (#1437) * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * removing docs folder, moving to pages * moving get started * removing JS out of template * removing refs to building md * creating index page * organizing files * cleaning up files * reorganizing based on 1430 * rearranging headings, removing comments * adding menu items * rearranging menu * fixing back link * removing top nav * splitting up into guides * adding home header * readding subpage header * adding titles to front matter * trying to fix this bug * removing redirect * fixing issues from feedback * removing overview from home page * removing test for anchors since it's no longer a long page * letting it pass with no tests * removing build * stub for docs readme * removing JSX guide (#1490) * Move plugin-related guide stubs to plugins (#1492) * moving a couple of guides to plugins * deleting svelte * Moving Create-Snowpack-App to its own page, minor changes to Getting Started page (#1494) * refactoring getting started, create-snowpack-app page * fixing typo * fixing typo * fixing typo * moving in menu * deleting cra docs * removing tailwind and postcss guide stubs (#1493) * removing supported libraries stub * removing eslint * outline/draft of getting started * copywriting * deleting overview, copy edits and image descriptions * copy edits * Plugins refactor (#1582) * merging in plugin page * linking to getting started * 1467 * #1457 * #1451 * #1445 * #1432 * 1457 * #1515 * fixing menu * adding search index * removing old file * removing old file * resolve issues * merging in master * add a sub-page navigation sidebar (#1586) * splitting up deployment guide, copy edits * fixing link * style guide * splitting up into pages (#1628) Co-authored-by: Drew Powers <drew@pow.rs> Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> Co-authored-by: Fred K. Schott <fkschott@gmail.com>
FredKSchott
added a commit
that referenced
this pull request
Nov 17, 2020
* React + Snowpack Guide (#1309) * adding react guide * fixing page title * fixing a sentence * copy edits * copy edits * Refactoring CSS/Diffing copy paste solution Spinning the CSS into seperate files to make them easier to refactor, testing a solution for diffing copy/paste * copy edits * copy edits, restructuring * adding some images * image optmization, frame * adding more images * Update repository URL * Incorporate guides.css * Add more guides styling * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Update www/guides/react.md Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * Fix indentation * changing header image * type in bash command * fixing typo * fixing typo * fixing typo * revising folder structure section * adding video * updating video * adding back gif * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * edits * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * copy edits * twitter share Co-authored-by: Drew Powers <drew@pow.rs> Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> * [WIP] Initial migration of docs to Snowpack (#1413) * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * removing JS out of template * Docs split into multiple pages (#1437) * initial migration of docs to Snowpack * removing boilerplate ref to canvas confetti * changing output directory * adding cssnano * ugh accidental commit of output dir * removing old original file * removing includes files in guides since those will be added later, fixing Snowpack config * fixing start command to process sass * removing generated file, readding test * re-adding cat behavior until we have seperate pages * error in package.json * fixing output directory * changing order of build commands * changing order of build commands * removing docs folder, moving to pages * moving get started * removing JS out of template * removing refs to building md * creating index page * organizing files * cleaning up files * reorganizing based on 1430 * rearranging headings, removing comments * adding menu items * rearranging menu * fixing back link * removing top nav * splitting up into guides * adding home header * readding subpage header * adding titles to front matter * trying to fix this bug * removing redirect * fixing issues from feedback * removing overview from home page * removing test for anchors since it's no longer a long page * letting it pass with no tests * removing build * stub for docs readme * removing JSX guide (#1490) * Move plugin-related guide stubs to plugins (#1492) * moving a couple of guides to plugins * deleting svelte * Moving Create-Snowpack-App to its own page, minor changes to Getting Started page (#1494) * refactoring getting started, create-snowpack-app page * fixing typo * fixing typo * fixing typo * moving in menu * deleting cra docs * removing tailwind and postcss guide stubs (#1493) * removing supported libraries stub * removing eslint * outline/draft of getting started * copywriting * deleting overview, copy edits and image descriptions * copy edits * Plugins refactor (#1582) * merging in plugin page * linking to getting started * 1467 * #1457 * #1451 * #1445 * #1432 * 1457 * #1515 * fixing menu * adding search index * removing old file * removing old file * resolve issues * merging in master * add a sub-page navigation sidebar (#1586) * splitting up deployment guide, copy edits * fixing link * style guide * splitting up into pages (#1628) Co-authored-by: Drew Powers <drew@pow.rs> Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com> Co-authored-by: Fred K. Schott <fkschott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deleted intsallOptions.alias options and Replace removing the addTrailingSlash with removeTrailingSlash, some discussion related to #1006
Testing
All tests have been passed.
Docs
The docs have been updated.