Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CSS module support, swap out outdated engine for postcss #1666

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

Testing

  • Test added (we weren't directly testing CSS Modules anywhere! Only indirectly in 1-2 other tests).

Docs

  • N/A

@vercel
Copy link

vercel bot commented Nov 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/4rf8aekje
✅ Preview: https://snowpack-git-improve-css-modules.pikapkg.vercel.app

@@ -79,6 +78,8 @@
"npm-run-path": "^4.0.1",
"open": "^7.0.4",
"p-queue": "^6.6.1",
"postcss": "^8.1.8",
"postcss-modules": "^3.2.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@FredKSchott FredKSchott merged commit 5b7ce4d into main Nov 26, 2020
@FredKSchott FredKSchott deleted the improve-css-modules branch November 26, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm 7 support
2 participants