Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file path to --stat output #217

Merged
merged 4 commits into from
Feb 18, 2020

Conversation

alex-saunders
Copy link
Collaborator

  • Adds full file path to --stat output when a specific file is defined as a web dependency
  • Strips common/ from the file path to remove clutter on common dependency output
  • Updates test cases to include appropriate scenario

Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add some type definitions to the format* function arguments just to help document the change? That should help #216 rebase

@FredKSchott FredKSchott self-requested a review February 18, 2020 22:09
@FredKSchott
Copy link
Owner

LGTM! Merge when you're ready

@alex-saunders alex-saunders merged commit 404b1f2 into FredKSchott:master Feb 18, 2020
@alex-saunders alex-saunders deleted the wip-stat-filename branch February 18, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants