Fix hmr proxy #417
Merged
Fix hmr proxy #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a reasonable fix to me |
|
Awesome! glad this was so easily supported in the native WS client |
|
ported to esm-hmr as well |
|
Great @FredKSchott . Don't forget to update assets/hmr.js to send esm-hmr also. |
|
doh! thanks for catching |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This commit fixes #414 by filtering the websockets upgrade requests that the hmr module will handle. Only the upgrade requests originating from the hmr.js will be processed. Uses custom header
Sec-WebSocket-Protocol : snowpack-hmrto do the filtering.