Enable compression on dev server responses #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredKSchott
reviewed
Jun 3, 2020
FredKSchott
approved these changes
Jun 3, 2020
stramel
force-pushed
the
ms/enable-compression
branch
from
43a3962 to
40c50b6
Compare
stramel
changed the title
|
Thanks @stramel |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
Enables compression for files sent in dev server.
I went ahead and added
branddeflatequickly since they were only a couple extra if statements. Let me know if you would like those removed.Without compression:
With gzip compression:
@FredKSchott We shouldn't be applying compression to binary files, I'm not currently accounting for that. Should I add a lib like
compressibleto determine it? (Update: Added as a separate commit which we can remove if you want)Future enhancements, we could check the file size and apply a threshold before compressing since sometimes smaller files can actually get larger and just cause an additional load to the server