Improve import resolution logic #519
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/83srn5l89 |
| const resolvedUrl = path.resolve(path.dirname(outPath), spec); | ||
| allProxiedFiles.add(resolvedUrl); | ||
| allProxiedFiles.add( | ||
| resolvedImportUrl.startsWith('/') |
There was a problem hiding this comment.
bug fix: we weren't resolving /_dist_/ URLs properly, since they get handled as absolute paths by path.resolve
| import srcFileExtensionMapping from './src-file-extension-mapping'; | ||
|
|
||
| const cwd = process.cwd(); |
There was a problem hiding this comment.
how do you feel about adding cwd to the config object? We do this in a few different places around the codebase, but it would be good to start moving towards a configurable cwd.
There was a problem hiding this comment.
I think that’s a great idea.
FredKSchott
force-pushed
the
improve-resolve-logic
branch
from
0cc5e05 to
66aef73
Compare
| styleEl.type = 'text/css'; | ||
|
|
||
| styleEl.appendChild(codeEl); | ||
| document.head.appendChild(styleEl); |
There was a problem hiding this comment.
Yes! This test will really come in handy for some upcoming work.
FredKSchott
force-pushed
the
improve-resolve-logic
branch
from
66aef73 to
d7fa9e1
Compare
Resolves #439, Resolves #443
This PR improves our ability to resolve a partial import (like
src/componentsorsrc/components/indexto importsrc/components/index.js). It solves a couple of bugs that users had been reporting, where behavior didn't match Node or Webpack's resolution logic (see resolved issues above).