support type-only packages (css-types) #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/rd8zmp9ea |
drwpow
reviewed
Jun 19, 2020
| // was given, assume a TS-types only package and ignore. | ||
| if (isImplicitEntrypoint && (depManifest.types || depManifest.typings)) { | ||
| return {type: 'IGNORE', loc: ''}; | ||
| } |
There was a problem hiding this comment.
Ah this is clever. I can see now we weren’t checking before if that entry point resolved.
I think require.resolve() here would work without that foundEntrypoint at the end, but practically that shouldn’t make a difference
FredKSchott
force-pushed
the
type-only-package-support
branch
from
bad41b5 to
4fd0843
Compare
FredKSchott
force-pushed
the
type-only-package-support
branch
from
4fd0843 to
ce8999c
Compare
FredKSchott
force-pushed
the
type-only-package-support
branch
from
ce8999c to
bd10647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #513
Ignore packages that only contain TS types, since they are purely for TS developers and never need to run in the browser.