Add programmatic install interface #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/djygqqvdo |
FredKSchott
changed the title
FredKSchott
force-pushed
the
programmatic-install
branch
from
4515b0a to
15e9692
Compare
FredKSchott
force-pushed
the
programmatic-install
branch
from
15e9692 to
56c13c2
Compare
FredKSchott
force-pushed
the
programmatic-install
branch
from
56c13c2 to
8bb7b65
Compare
FredKSchott
force-pushed
the
programmatic-install
branch
from
8bb7b65 to
966fbb7
Compare
drwpow
reviewed
Jun 22, 2020
| @@ -14,13 +14,13 @@ import {InputOptions, OutputOptions, rollup, RollupError} from 'rollup'; | |||
| import validatePackageName from 'validate-npm-package-name'; | |||
| import {EnvVarReplacements, SnowpackConfig} from '../config.js'; | |||
| import {resolveTargetsFromRemoteCDN} from '../resolve-remote.js'; | |||
| import {rollupPluginCatchUnresolved} from '../rollup-plugin-catch-unresolved.js'; | |||
There was a problem hiding this comment.
lol I can't take credit for this, there's a great "Organize Imports" command inside of VSCode that automates this :)
drwpow
reviewed
Jun 22, 2020
| @@ -1,4 +1,3 @@ | |||
| - snowpack installing... | |||
drwpow
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the build command to run an install on the final build, before it's written to disk. A big part of how we will solve #475. See more background here: #475 (comment)
build&dev: Some small clean up of build & dev but keeps them calling the CLI interface for now.webModulesPathto our new import resolver, instead of having the import resolver figure it out itselfscan-imports: Separate out the "file collection" and "import scanning" logic into two functions, so that build can call it with an already collected set of files.install: The meat of the change - moves the core install logic out of the existing CLIcommand, and into a more programmatic interface /w detailed return object.