Add no-source-maps option #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be enough to implement #61 in the most minimal way. Tested the concept on my local machine (by hard-coding `sourcemaps: false`) and it works.
|
awesome! Thanks for your patience and sorry for the delay in reviewing. LGTM! |
FredKSchott
added a commit
that referenced
this pull request
Jul 25, 2019
* noSourceMaps -> sourceMap (match the value we get back from our args parser) * --no-source-maps -> --no-source-map (to match TS's sourceMap)
|
Did some cleanup in a0663e0 to match our yargs parser correctly |
drwpow
pushed a commit
that referenced
this pull request
Jul 24, 2020
drwpow
pushed a commit
that referenced
this pull request
Jul 27, 2020
drwpow
pushed a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be enough to implement #61 in the most minimal way. Tested the concept on my local machine (by hard-coding
sourcemap: false) and it works.