Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory view #1491

Merged
merged 13 commits into from
Oct 16, 2021
Merged

Directory view #1491

merged 13 commits into from
Oct 16, 2021

Conversation

jung-kim
Copy link
Collaborator

@jung-kim jung-kim commented Oct 13, 2021 •
edited
Loading

Screen Shot 2021-10-12 at 7 31 49 PM

  • at directory view, list sub directories that are git repos
  • fix unreliable throttling git process logic
  • run lint only once

jung-kim
jung-kim commented Oct 13, 2021
View reviewed changes
source/git-promise.js
gitSem.wait(() => {
resolve();
});
});
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, there are some race conditions here that would lock up if computer is running hot.

@campersau
Copy link
Collaborator

Can you please run npm run lint and fix all errors, some errors are automatically fixed if you run npm run format?

@jung-kim
Copy link
Collaborator Author

@campersau done!

campersau
campersau reviewed Oct 14, 2021
View reviewed changes
components/path/path.html Outdated Show resolved Hide resolved
components/path/path.js Show resolved Hide resolved
components/path/path.js Show resolved Hide resolved
components/path/path.js Outdated Show resolved Hide resolved
github-actions bot and others added 6 commits October 15, 2021 00:11
@github-actions
Bump Dependencies
bb4f491
@jung-kim @campersau
Update components/path/path.js
a548762 
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
@jung-kim @campersau
Update components/path/path.html
0829f30 
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
@jung-kim
Merge remote-tracking branch 'origin/bumpdependencies' into directory…
505a387 
…_view

# Conflicts:
#       package-lock.json
#       package.json
@jung-kim
Merge remote-tracking branch 'origin/directory_view' into directory_view
05e5501
@jung-kim
code review
ff57d55
@jung-kim jung-kim mentioned this pull request Oct 15, 2021
Closed
campersau
campersau approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@campersau campersau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jung-kim jung-kim merged commit c33ab68 into master Oct 16, 2021
@jung-kim jung-kim deleted the directory_view branch October 16, 2021 01:18
@campersau campersau mentioned this pull request Jan 29, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@campersau campersau campersau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jung-kim @campersau