Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slic3r-tools updates #162

Merged
merged 1 commit into from
Jun 5, 2020
Merged

slic3r-tools updates #162

merged 1 commit into from
Jun 5, 2020

Conversation

limikael
Copy link
Contributor

No description provided.

@limikael
Copy link
Contributor Author

This update includes the merge of the following PRs from @mbenkmann:

limikael/freecad-slic3r-tools#8
limikael/freecad-slic3r-tools#9
limikael/freecad-slic3r-tools#10

@luzpaz
Copy link
Collaborator

luzpaz commented Jan 11, 2020

@limikael no need to merge any changes from your repo in to FreeCAD-addons since the addon manager automatically gets the latest changes automagically. The addon manager will download the default specified 'master' branch (in quotations since some repos designate their dev branches as the default branch that users see when they visit the repo).

In other words, even if the Github Addon Manager repo is showing an obsolete commit as the latest commit, when a user activates the FreeCAD Addon Manager utility, the software redirects to the external Github repo of said dev and retrieves the most up to date changes. Does that make sense.

Every so often yorik or myself will run an update on the Github FreeCAD-addons repo to pull in said changes. But it's purely a cosmetic change.

@yorikvanhavre
Copy link
Member

Sorry forgot to come look here guys.
Indeed FreeCAD always pushes the latest master branch from each addon, no matter what it says here on github (we basically just take the list of addons from here). So there is no need to update anything. But I'll merge your PR anyway just for the sake of it ;)

@yorikvanhavre yorikvanhavre merged commit 18969a5 into FreeCAD:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants