Add defer=false to all <Helmet> elements

If defer is true (default value) the document title isn't updated while browser tab is inactive. See nfl/react-helmet#314 and https://freefeed.net/support/5bd48fee-226c-4393-beca-0fa7e94398a5#comment-ef68b416-6eb9-415e-ab33-c5562e6dc977 (bug report)
FreeFeed · May 1, 2020 · c8c3ec6 · c8c3ec6
1 parent c0556ea
commit c8c3ec6
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/components/all-groups.jsx b/src/components/all-groups.jsx
@@ -25,7 +25,7 @@ export default function AllGroups() {
 
   return (
     <div className="content">
-      <Helmet title={`All Groups - ${CONFIG.siteTitle}`} />
+      <Helmet title={`All Groups - ${CONFIG.siteTitle}`} defer={false} />
       <div className="box">
         <div className="box-header-timeline">All Groups</div>
         <div className="box-body">

diff --git a/src/components/color-theme-setter.jsx b/src/components/color-theme-setter.jsx
@@ -15,7 +15,7 @@ class ColorSchemeSetterBase extends Component {
 
   render() {
     return (
-      <Helmet>
+      <Helmet defer={false}>
         <meta name="theme-color" content={this.props.darkTheme ? 'hsl(220, 9%, 10%)' : 'white'} />
       </Helmet>
     );

diff --git a/src/components/group-settings.jsx b/src/components/group-settings.jsx
@@ -73,7 +73,7 @@ export default function GroupSettings({ params: { userName: username } }) {
 function Layout({ username, children }) {
   return (
     <div className="box">
-      <Helmet title={`'${username}' group settings - ${CONFIG.siteTitle}`} />
+      <Helmet title={`'${username}' group settings - ${CONFIG.siteTitle}`} defer={false} />
       <div className="box-header-timeline">Group settings</div>
       <div className="box-body">{children}</div>
     </div>

diff --git a/src/components/layout.jsx b/src/components/layout.jsx
@@ -149,7 +149,7 @@ class Layout extends React.Component {
     return (
       <div className={layoutClassNames}>
         <ErrorBoundary>
-          <Helmet title={props.title} />
+          <Helmet title={props.title} defer={false} />
           <ColorSchemeSetter />
           <SVGSymbolDeclarations />
 

diff --git a/src/components/settings/layout.jsx b/src/components/settings/layout.jsx
@@ -94,7 +94,7 @@ export default function Layout({ children, router }) {
 export function SettingsPage({ title, header = title, children }) {
   return (
     <>
-      <Helmet title={title} />
+      <Helmet title={title} defer={false} />
       <h3 className={styles.pageHeader}>{header}</h3>
       {children}
     </>