Also set include directories for the BUILD_INTERFACE #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the directory `include/` was included into the include directories by a global directive as well as using the INSTALL_INTERFACE. However, when including the project with FetchContent into another project, cmake uses the BUILD_INTERFACE to declare target properties, in particular the target's include directories, but it does not use the project-wide include directories. Thus, also include the directory into each targets include directories via its BUILD_INTERFACE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the directory
include/was included into the includedirectories by a global directive as well as using the
INSTALL_INTERFACE. However, when including the project with
FetchContent into another project, cmake uses the BUILD_INTERFACE to
declare target properties, in particular the target's include
directories, but it does not use the project-wide include directories.
Thus, also include the directory into each targets include directories
via its BUILD_INTERFACE.
This fixes build failures of projects that include freeopcua via FetchContent. Previously, those builds failed because the compiler could not find the header files.
Fixes robocup-logistics/gazebo-rcll#57.