WIP: attempt to update to last spec, broken, importer needs to be fixed #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2020
|
fixed in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help welcome. We need to fix parser and I have no time currently
the issue (as far as I remember) is that the xml now looks like this.
While before itwas
<ArrayDimensions>0</ArrayDimensions>So the current code is trying to create an object of type UInt32 which does not exist as this should be registered as a number and just write code like :
obj.ArrayDimentsions = 0(you get an attribute error since the code is written similar to:gettatr(ua, myobj))This is touchy to fix since the syntax without the datatype is still used at several other places.
Also to complicate things, the entire xml address space is now only one file while before it was several small files. This is a big issue on machine with little memory..